gamesh411 added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:95 // Stores the region of the environment pointer of 'main' (if present). -REGISTER_TRAIT_WITH_PROGRAMSTATE(EnvPtrRegion, const MemRegion *) +REGISTER_TRAIT_WITH_PROGRAMSTATE(MainEnvPtrRegion, const MemRegion *) + ---------------- The state modelling is refined to model the env region coming from the main function and the getenv calls. ================ Comment at: clang/test/Analysis/cert/env34-c.c:6 +// +// TODO: write test cases that follow the pattern: +// "getenv -> store pointer -> setenv -> use stored pointer" ---------------- This test file is incomplete. I would welcome suggestions here as to how to test this. Should a new file be created for the config option with different test cases, or is this file to be extended? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154603/new/ https://reviews.llvm.org/D154603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
