djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.

Basically looks good.


================
Comment at: lib/Format/Format.cpp:806
@@ -805,2 +805,3 @@
           FormatTokenLexer &Tokens, tooling::Replacements &Result) override {
+    tooling::Replacements RunResult;
     deriveLocalStyle(AnnotatedLines);
----------------
Call this "RequoteChanges".

================
Comment at: lib/Format/Format.cpp:831
@@ -830,1 +830,3 @@
+    RunResult = RunResult.merge(Whitespaces.generateReplacements());
+    return RunResult;
   }
----------------
Just

  return RequoteChanges.merge(Whitespaces.generateReplacements());


https://reviews.llvm.org/D24155



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to