[PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

[Eugene Zelenko via cfe-commits]

Eugene.Zelenko created this revision.
Eugene.Zelenko added a reviewer: hokein.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.

I checked this patch on my own build on RHEL 6. Regressions were OK.

Repository:
  rL LLVM

https://reviews.llvm.org/D24179

Files:
  include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
  include-fixer/find-all-symbols/FindAllSymbolsAction.h

Index: include-fixer/find-all-symbols/FindAllSymbolsAction.h
===================================================================
--- include-fixer/find-all-symbols/FindAllSymbolsAction.h
+++ include-fixer/find-all-symbols/FindAllSymbolsAction.h
@@ -10,13 +10,15 @@
 #ifndef LLVM_CLANG_TOOLS_EXTRA_FIND_ALL_SYMBOLS_FIND_ALL_SYMBOLS_ACTION_H
 #define LLVM_CLANG_TOOLS_EXTRA_FIND_ALL_SYMBOLS_FIND_ALL_SYMBOLS_ACTION_H
 
-#include "FindAllMacros.h"
 #include "FindAllSymbols.h"
 #include "HeaderMapCollector.h"
 #include "PragmaCommentHandler.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
 #include "clang/Frontend/CompilerInstance.h"
-#include "clang/Frontend/FrontendActions.h"
+#include "clang/Frontend/FrontendAction.h"
 #include "clang/Tooling/Tooling.h"
+#include "llvm/ADT/StringRef.h"
+#include <memory>
 
 namespace clang {
 namespace find_all_symbols {
@@ -46,7 +48,7 @@
       const HeaderMapCollector::RegexHeaderMap *RegexHeaderMap = nullptr)
       : Reporter(Reporter), RegexHeaderMap(RegexHeaderMap) {}
 
-  virtual clang::FrontendAction *create() override {
+  clang::FrontendAction *create() override {
     return new FindAllSymbolsAction(Reporter, RegexHeaderMap);
   }
 
Index: include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
===================================================================
--- include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
+++ include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
@@ -8,6 +8,10 @@
 
//===----------------------------------------------------------------------===//
 
 #include "FindAllSymbolsAction.h"
+#include "FindAllMacros.h"
+#include "clang/Lex/PPCallbacks.h"
+#include "clang/Lex/Preprocessor.h"
+#include "llvm/ADT/STLExtras.h"
 
 namespace clang {
 namespace find_all_symbols {



Index: include-fixer/find-all-symbols/FindAllSymbolsAction.h
===================================================================
--- include-fixer/find-all-symbols/FindAllSymbolsAction.h
+++ include-fixer/find-all-symbols/FindAllSymbolsAction.h
@@ -10,13 +10,15 @@
 #ifndef LLVM_CLANG_TOOLS_EXTRA_FIND_ALL_SYMBOLS_FIND_ALL_SYMBOLS_ACTION_H
 #define LLVM_CLANG_TOOLS_EXTRA_FIND_ALL_SYMBOLS_FIND_ALL_SYMBOLS_ACTION_H
 
-#include "FindAllMacros.h"
 #include "FindAllSymbols.h"
 #include "HeaderMapCollector.h"
 #include "PragmaCommentHandler.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
 #include "clang/Frontend/CompilerInstance.h"
-#include "clang/Frontend/FrontendActions.h"
+#include "clang/Frontend/FrontendAction.h"
 #include "clang/Tooling/Tooling.h"
+#include "llvm/ADT/StringRef.h"
+#include <memory>
 
 namespace clang {
 namespace find_all_symbols {
@@ -46,7 +48,7 @@
       const HeaderMapCollector::RegexHeaderMap *RegexHeaderMap = nullptr)
       : Reporter(Reporter), RegexHeaderMap(RegexHeaderMap) {}
 
-  virtual clang::FrontendAction *create() override {
+  clang::FrontendAction *create() override {
     return new FindAllSymbolsAction(Reporter, RegexHeaderMap);
   }
 
Index: include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
===================================================================
--- include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
+++ include-fixer/find-all-symbols/FindAllSymbolsAction.cpp
@@ -8,6 +8,10 @@
 //===----------------------------------------------------------------------===//
 
 #include "FindAllSymbolsAction.h"
+#include "FindAllMacros.h"
+#include "clang/Lex/PPCallbacks.h"
+#include "clang/Lex/Preprocessor.h"
+#include "llvm/ADT/STLExtras.h"
 
 namespace clang {
 namespace find_all_symbols {

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits