mikecrowe added a comment. Thanks for the review.
================ Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:356-357 + if (ArgCount) + ArgRotates.push_back( + std::make_tuple(FS.getArgIndex() + ArgsOffset, ArgCount)); +} ---------------- PiotrZSL wrote: > Good point. ================ Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.h:73 + // puts the width and preicision first. + std::vector<std::tuple<unsigned, unsigned>> ArgRotates; + ---------------- PiotrZSL wrote: > NOTE: You can use std::pair here. True, but in my mind `std::pair` only exists because `std::tuple` couldn't be implemented in the C++98. I was going to change it to use `std::pair` anyway, but I notice that I already use `std::tuple` for `ArgFixes` just above. Should I change both of them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154283/new/ https://reviews.llvm.org/D154283 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
