FreddyYe added a comment. In D154209#4466304 <https://reviews.llvm.org/D154209#4466304>, @RKSimon wrote:
> LGTM - but it would be good to fix silvermont / westmere cases as well with > suitable test coverage Thanks review! After D151696 <https://reviews.llvm.org/D151696> landed, they can be both fixed and there will be more tests cover such missing like clang/test/Preprocessor/predefined-arch-macros.c. And about cpu_specific test coverage, I'll consider a way to refine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154209/new/ https://reviews.llvm.org/D154209 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
