arsenm added a comment. lgtm except for dropping test coverage
================ Comment at: clang/test/Driver/hip-macros.hip:20 // RUN: -mwavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s -// WAVE64-DAG: #define __AMDGCN_WAVEFRONT_SIZE 64 -// WAVE32-DAG: #define __AMDGCN_WAVEFRONT_SIZE 32 ---------------- This shouldn't drop the check for the old one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154207/new/ https://reviews.llvm.org/D154207 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
