ABataev added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2168 + ElementType = VLAType->getElementType(); + llvm::Value *VLASize = VLASizeMap[VLAType->getSizeExpr()]; + if (!VLASize) ---------------- Use VLASizeMap.find() instead ================ Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ---------------- doru1004 wrote: > ABataev wrote: > > doru1004 wrote: > > > ABataev wrote: > > > > 1. Is it possible that VariableArrayType does not have VLA size? > > > > 2. Fix param name > > > @ABataev How would point 1 happen? > > You're adding a function that checks if VLA type has VLA size. I'm asking, > > if it is possible for VLA type to not have VLA size at all? Why do you need > > this function? > This function checks if the expression of the size of the VLA has already > been emitted and can be used. Why the emission of VLA size can be delayed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
