thakis added inline comments. ================ Comment at: lib/Parse/ParseDeclCXX.cpp:4031 @@ +4030,3 @@ + ConsumeToken(); + if (Name->getName() == "uuid" && Tok.is(tok::l_paren)) + ParseMicrosoftUuidAttributeArgs(Name, Loc, attrs); ---------------- aaron.ballman wrote: > Silently ignoring seems like the wrong thing to do -- can we diagnose (even > if it's a less-than-ideal diagnostics with a fixme)? We still skip the majority of [] contents. Maybe the token 'uuid' can appear in some other attribute, followed by something else. So we probably shouldn't diag on 'uuid' followed by not-'(' (right?). Do you want me to add a diagnostic for 'uuid' '{'? What about 'uuid' '['?
https://reviews.llvm.org/D23895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits