benlangmuir added a comment.

> Just realized this most likely won't work if the case-insensitive VFS is 
> specified with wrong spelling too, e.g. Fw.framework.

Is this about the spelling in the VFS definition itself, or about the path 
being looked up? If it's the VFS definition maybe we can say that's a bug for 
whoever wrote the VFS? Ideally we could diagnose but I'm not sure we want to 
pay for a lot of calls to realpath.



================
Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:876
+    /// Chain of parent directory entries for \c E.
+    std::vector<Entry *> Parents;
+
----------------
SmallVector?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135849/new/

https://reviews.llvm.org/D135849

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to