MaskRay added a comment.

Thank you for implementing this warning. Side note: it would be better to (a) 
fix the tests separately from (b) implementing the warning and (c) adding tests 
to demonstrate the warning.
This way the patch is more focused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153430/new/

https://reviews.llvm.org/D153430

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D153430: [Clan... Fangrui Song via Phabricator via cfe-commits

Reply via email to