jrtc27 added a comment. In D147875#4448545 <https://reviews.llvm.org/D147875#4448545>, @hans wrote:
> I noticed that at least for some cases of `-Wformat`, the line numbers on the > left seem to be off: https://github.com/llvm/llvm-project/issues/63524 That's because DisplayLineNo refers to the line of the diagnostic, not the first source line, and then counts up. What's the reason for DisplayLineNo in the first place? Given the printed line comes from LineNo, surely we should be using LineNo instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
