cor3ntin added inline comments.

================
Comment at: clang/test/Lexer/utf8-char-literal.cpp:22
 char b = u8'\x80';   // ok
-char c = u8'\u0080'; // expected-error {{universal character name refers to a 
control character}}
+char c = u8'\u0000'; // ok
 char d = u8'\u1234'; // expected-error {{character too large for enclosing 
character literal type}}
----------------
shafik wrote:
> Why change this test line?
0x80 is too big to be represented in a char (and we have tests for that, I 
wanted a positive tests for control characters)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153621/new/

https://reviews.llvm.org/D153621

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to