donat.nagy added inline comments.
================
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1309
+ [Node, Note](PathSensitiveBugReport &BR) -> std::string {
+ if (Node->succ_size() > 1)
+ return Note.str();
----------------
It's surprising to see this check inside the lambda, as its result does not
depend on `BR`. My best guess is that it's performed here because the
successors of `Node` will appear between the execution of the surrounding code
and the execution of this lambda.
However, CheckerContext.h line 69-70 claims that "checkers should not retain
the node in their state since the nodes might get invalidated." which would
imply that the captured `Node` might be invalid when the lambda is called.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153612/new/
https://reviews.llvm.org/D153612
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
