erichkeane added inline comments.
================ Comment at: clang/lib/AST/ExprConstant.cpp:8920 + if (HasValidResult) + CCEDiag(E, diag::note_constexpr_invalid_void_star_cast) + << SubExpr->getType() << Info.getLangOpts().CPlusPlus26 ---------------- Does this diagnostic work? In the case of the `!C++26`, the arity of the message is different, right? Do you have a test for this in not c++26 mode that you can post? I Am not sure we do 'fill ins' for discarded 'select' branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153702/new/ https://reviews.llvm.org/D153702 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
