akyrtzi marked an inline comment as done.
akyrtzi added inline comments.

================
Comment at: clang/unittests/Tooling/DependencyScannerTest.cpp:274
+    llvm::ErrorOr<std::unique_ptr<llvm::vfs::File>>
+    openFileForRead(const Twine &Path) override {
+      ReadFiles.push_back(Path.str());
----------------
benlangmuir wrote:
> Should we add `status` override as well? I think we don't want to stat it 
> either.
Good idea, see updated patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153670/new/

https://reviews.llvm.org/D153670

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to