yronglin marked an inline comment as done. yronglin added inline comments.
================ Comment at: clang/lib/AST/ExprConstant.cpp:4893 + // Stop evaluate if E is a RecoveryExpr. + if (isa<RecoveryExpr>(E)) + return false; ---------------- erichkeane wrote: > I'd probably suggest `E->containsErrors()` instead, to cover cases where > we're not the 'root' of a recovery expr? So something like: > > `switch(func_call(unknown_value))` > > should create a dependent call expr, but would still contain errors. Thanks! Use `E->containsErrors()` and added into release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
