Hi, I uploaded the incorrect patch, it shouldn't have included the -fexceptions-fp-math because we decided to use trapping-math and therefore I removed these test lines in the quick fix.
Regression test test/CodeGen/noexceptionsfpmath.c makes sure -fno-trapping-math ends up as a function attribute, and I relied on that. Flag -fno-trapping-math is used a lot in test/Driver/fast-math.c, but you are right that there is no test that test that explicitly test the output for this. I will add a test case for that. Thanks, Sjoerd. -----Original Message----- From: Renato Golin [mailto:renato.go...@linaro.org] Sent: 31 August 2016 11:10 To: Sjoerd Meijer Cc: Clang Commits; Diana Picus; James Molloy Subject: Re: r280065 - Fix for commit 280064 that break the build. On 30 August 2016 at 09:56, Sjoerd Meijer via cfe-commits <cfe-commits@lists.llvm.org> wrote: > Author: sjoerdmeijer > Date: Tue Aug 30 03:56:00 2016 > New Revision: 280065 > > URL: http://llvm.org/viewvc/llvm-project?rev=280065&view=rev > Log: > Fix for commit 280064 that break the build. Any more info on this? Is this being worked to replace the deleted tests? cheers, -renato IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
