iains marked an inline comment as done. iains added a comment. In D145965#4431997 <https://reviews.llvm.org/D145965#4431997>, @ChuanqiXu wrote:
>> It is a case that we have supported; the user puts in a use of a decl but >> forgets to import the module exporting it (I agree it is not _exactly_ a >> "typo" in terms of names, but the diagnostics counts it in the same way) > > I got your point. But I prefer to implement an all-visible mode (not > available for users) for such situations. And I still think it is not problem > for the special case. Since this is patch is working for **internal** decls. Yes, but AFAIR we also support the user naming an internal entity and then say "you must export PP before using it". (I am sure that these changes were needed to avoid regressing existing diagnostics). I have some ideas now - will thin about them during travel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
