AMS21 added a comment.

Regarding the problems with attributes like nodiscard. I'm honestly not quite 
sure, but from the way the check is implemented and the warning is worded, it 
sounds to me like the attributes should come after LIBC_INLINE. Although 
looking at the Styleguide for libc, I didn't find anything the placement of the 
macro there.

I thinks its best for now to leave the behavior as it was.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153218/new/

https://reviews.llvm.org/D153218

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to