jhuber6 added inline comments.
================ Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8 +// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s +// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is read only ---------------- jdoerfert wrote: > yaxunl wrote: > > arsenm wrote: > > > Can you use -verify and expected-no-diagnostics? CHECK-NOT is really > > > fragile > > -verify only works with clang -cc1, whereas we want to make sure there is > > no warning for the whole compilation invoked by clang driver > let's then check-not for any warning? It's probably reasonable that this shouldn't return any random errors so I'm fine with false positives. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153123/new/ https://reviews.llvm.org/D153123 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits