Manna marked an inline comment as done. Manna added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368 - VD = VD->getCanonicalDecl(); + VD = cast<VarDecl>(VD->getCanonicalDecl()); auto I = FunctionGlobalizedDecls.find(CGF.CurFn); ---------------- aaron.ballman wrote: > This is unnecessary, `getCanonicalDecl()` can never return a null pointer (it > will return `this`, at the very least) Thank you @aaron.ballman for reviews! I agree with you. My previous analysis was wrong. I have removed this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
