zahiraam added inline comments.
================ Comment at: clang/include/clang/Basic/IdentifierTable.h:89 +static constexpr int FirstInterestingIdentifierID = LastObjCKeywordID + 1; +static constexpr int LastInterestingIdentifierID = LastObjCKeywordID + tok::NUM_INTERESTING_IDENTIFIERS; +static constexpr int FirstBuiltinID = LastInterestingIdentifierID + 1; ---------------- rjmccall wrote: > I see that I had a bug in my suggestion: I had meant to write > `LastInterestingIdentifierID = FirstInterestingIdentifierID + > tok::NUM_INTERESTING_IDENTIFIERS - 2;` but I left it in terms of > `LastObjCKeywordID` instead, making the ranges off by 1. Your math fixes > that; sorry about that. I do think it would be clearer if each of these > chained off the last one, the way I meant to have it, though. So with your > ranges (which leave space to explicitly represent `not_interesting`), that > would look like `LastInterestingIdentifierID = FirstInterestingIdentifierID + > tok::NUM_INTERESTING_IDENTIFIERS - 1;`. > > I'm not going to push you to not represent `not_interesting`, since you seem > to have deliberately changed things back that way, and I don't think it > matters that much. Although maybe you did that just because it didn't work > in the code I gave you? It would be more consistent with the other enums to > not explicitly represent `not_interesting`. Sorry @rjmccall, I didn't mean to go against your proposal. It's a misunderstanding of my part. I was going through the debugger with an objc test case and was under the impression that not_keyword was added. Will make the change to not represent not_interesting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
