schittir added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed() || - lstate->isUnlockedAndPossiblyDestroyed()); + assert(lstate && (lstate->isUntouchedAndPossiblyDestroyed() || + lstate->isUnlockedAndPossiblyDestroyed())); ---------------- steakhal wrote: > schittir wrote: > > steakhal wrote: > > > > > Wouldn't it be better to do an with a comment, like below? > > ``` > > assert(lstate && "lstate should not be null"); > > ``` > As a Static Analyzer dev I don't think its necessary. StateRefs are > ubiquitous and here we probably know it cannot be null. And if it turns out > to be null we would get a segfault. So that sense I don't think its necessary. > > > And speaking of a comment like "it should not be null" I think the segfault > would sort of imply that. That makes sense! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152977/new/ https://reviews.llvm.org/D152977 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
