shchenz added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700 + CmdArgs.push_back(Args.MakeArgString( + Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs)); + else if (!UseIntegratedAs) { ---------------- qiongsiwu1 wrote: > shchenz wrote: > > Seems other options leverage the default value in the back end, for example > > the default value for `DisableIntegratedAS` in backend is false, so when > > the front end requires integrated-as, maybe we can save the option here? > Ah thanks for the comment! > > > maybe we can save the option here? > > Could you help me understand what we mean by "the option"? Do we mean saving > (or using?) the value of `-f[no]-integrated-as` explicitly here somehow > instead of relying on `ToolChain.useIntegratedAs()`? How do we intend to use > the saved option value? My understanding is that `DisableIntegratedAS` takes > its value from the option `-no-integrated-as` if `-no-integrated-as` is > specified. As pointed out eariler, `DisableIntegratedAS` is false by default. > This code explicitly sets `-no-integrated-as` to `0` or `1`, so for the LTO > use case, we overwrite the back end default since the option is always > present. For example, if front-end requires to use integrated-assembler which is same with back-end's default value, we don't need to pass `-no-integrated-as=0`? We only pass the option `-no-integrated-as=1` when `if (IsOSAIX && !UseIntegratedAs)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152924/new/ https://reviews.llvm.org/D152924 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits