nemanjai added inline comments.
================ Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1785 + if (static_cast<const PPCTargetMachine &>(TM).hasGlibcHWCAPAccess()) + OutStreamer->emitSymbolValue( ---------------- This probably deserves a comment along the lines of: ``` // Emit a reference to a symbol exported by versions of GLIBC // that provide the HWCAP access. If a program built with this // is run on a system with an old GLIBC, it should cause a // load-time error rather than loading garbage. ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152914/new/ https://reviews.llvm.org/D152914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
