mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land.
Looks great to me, thanks! (Didn't test it myself yet though.) Just one small nit. ================ Comment at: llvm/include/llvm/Option/Arg.h:53 + /// This is used for generating an "argument unused" warning (without + /// clang::driver::options::TargetSpecific) or "unsupported option" error + /// (with TargetSpecific). ---------------- Technically, as this is a llvm level API, talking about clang specific behaviours here is a bit at the wrong level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152856/new/ https://reviews.llvm.org/D152856 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
