goldstein.w.n added inline comments.

================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1764
+      if (ICA.processFunction(F))
+        Changed.insert(F);
+  }
----------------
Do we actually need to add the function to the changed list here? We aren't 
modifying the functions attributes, only callsites within the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152226/new/

https://reviews.llvm.org/D152226

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to