MaskRay added a comment.

In D152570#4417752 <https://reviews.llvm.org/D152570#4417752>, @dankm wrote:

> @MaskRay if this meets your approval, are you able to commit it for me?

LG, but give @aaron.ballman and @shafik some time if they have opinions.

In D152570#4416201 <https://reviews.llvm.org/D152570#4416201>, @dankm wrote:

> Maybe for the description something like:
>
>   Apply -fmacro-prefix-map to anonymous tags in template arguments
>
> Do I need to mention TypePrinter?

I think it's fine to not mention it in the subject. You can mention TypePrinter 
in the description, though.



================
Comment at: clang/docs/ReleaseNotes.rst:500
   (`#50244 <https://github.com/llvm/llvm-project/issues/50244>_`).
+- Fix lambdas in template arguments not respecting ``-fmacro-prefix-map``
+  (`#63219 <https://github.com/llvm/llvm-project/issues/63219>`_)
----------------
This needs adjustment as the subject has changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152570/new/

https://reviews.llvm.org/D152570

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D... Dan McGregor via Phabricator via cfe-commits
    • [PAT... Fangrui Song via Phabricator via cfe-commits
    • [PAT... Aaron Ballman via Phabricator via cfe-commits
    • [PAT... Dan McGregor via Phabricator via cfe-commits
    • [PAT... Dan McGregor via Phabricator via cfe-commits
    • [PAT... Fangrui Song via Phabricator via cfe-commits
    • [PAT... Fangrui Song via Phabricator via cfe-commits
    • [PAT... Zixuan Wu via Phabricator via cfe-commits
    • [PAT... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits

Reply via email to