jyknight added inline comments.

================
Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1333
+        CalleeDecl->getOverloadedOperator() == OO_Delete) {
+      CallOrInvoke->addParamAttr(0, llvm::Attribute::AllocatedPointer);
+    }
----------------
Perhaps we should add this attribute to the fn decl and all calls? I think that 
unlike "alloc-family" in the future patch, this attribute probably doesn't need 
to be only applied to these "builtin" uses?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123085/new/

https://reviews.llvm.org/D123085

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D123085: CGExprCXX:... Augie Fackler via Phabricator via cfe-commits
    • [PATCH] D123085: CGExp... James Y Knight via Phabricator via cfe-commits

Reply via email to