aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/test/AST/Interp/records.cpp:650 +}; +#endif ---------------- tbaeder wrote: > aaron.ballman wrote: > > We should also have test cases for calling virtual functions from within a > > constructor and a destructor, as that has special semantics. e.g., > > https://godbolt.org/z/snaj1zfM5 > That's broken right now of course. I'l add the test and adjust the expected > output. I'll probably have to save a few bits for "things we're currently > doing" (like evaluating a constructor), but in a later patch. > > FWIW, I expanded your test a bit: https://godbolt.org/z/vq5xT3xvq and it only > fails in clang - with a reference: > ``` > // CWG issue 1517: we're constructing a base class of the object described > by > // 'This', so that object has not yet begun its period of construction and > // any polymorphic operation on it results in undefined behavior. > ``` Handled in a follow-up is fine by me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
