stuij added a comment. In D149444#4415306 <https://reviews.llvm.org/D149444#4415306>, @MaskRay wrote:
> Normally we implement the feature in llvm/ first, and the `clang/lib/Driver` > change should be the last patch. Yes good point. I won't commit it yet. For this feature we're using Phab as a vehicle to swap patches, so we're reviewing these upstream as they become available. ================ Comment at: clang/test/Driver/arm-execute-only.c:1 -// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: %clang -c -### --target=thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: FileCheck -allow-empty --check-prefix CHECK-EXECUTE-ONLY %s ---------------- MaskRay wrote: > If you don't check -cc1 options with FileCheck, you can also replace `-###` > with `-fdriver-only -Werror` and drop two `-NOT:` patterns below. You can > play with some examples to see its effect:) > > If the `clang -c -fdriver-only -Werror` command gives no output, you can use > `... 2>&1 | count 0` Very useful info. Thanks for the tips! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
