oontvoo added a comment. In D144999#4405793 <https://reviews.llvm.org/D144999#4405793>, @fdeazeve wrote:
> I believe this is breaking the LLDB tests: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56106/changes > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/buildTimeTrend > > Build 56105 was passing, and the only relevant change seems to come from this > review. > > Note that the failure is due to a test that is now passing: > > Unexpectedly Passed Tests (1): > lldb-shell :: Unwind/prefer-debug-over-eh-frame.test > > Maybe we forgot to re-enable that test? The behaviour has changed - I can update the test. Question: Do you prefer to have it set a flag that goes back to the old behaviour? OR change to to expect-passing? (My vote would be on have it expect the test to pass because, from reading the test, this is preferring debug-frame over eh-frame, which probably isn't ideal in the new code beacuse all non-canonical personality symbols will now be eh-frame) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
