michaelplatings added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246
+ // No multilibs selected so return a single default multilib.
+ static llvm::SmallVector<Multilib> Default = {Multilib()};
+ return llvm::iterator_range<
+ llvm::SmallVector<Multilib>::const_reverse_iterator>(Default.rbegin(),
+ Default.rend());
----------------
phosek wrote:
> What's the reason for returning an empty `Multilib`, could we instead return
> and empty range?
This is for consistency with the previous behaviour, which would fall back to
using a default sysroot if no matching multilib was found.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143075/new/
https://reviews.llvm.org/D143075
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
