tra added inline comments.
================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:615
setFP16OperationAction(Op, MVT::v2f16, Legal, Expand);
- }
-
- for (const auto &Op : {ISD::FADD, ISD::FMUL, ISD::FSUB, ISD::FMA}) {
setBF16OperationAction(Op, MVT::bf16, Legal, Promote);
setBF16OperationAction(Op, MVT::v2bf16, Legal, Expand);
----------------
kushanam wrote:
> tra wrote:
> > There's still something odd with this patch. The `setBF16OperationAction`
> > is not in the upstream, but it does not show up in the diff on phabricator.
> >
> > Please do rebase on top of the LLVM and make sure that all your changes are
> > on the git branch you use to send the patch to phabricator. If in doubt how
> > to get `arc` to do it correctly, you can always create and upload the diff
> > manually as described here:
> > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
> It is in the first commit, isn't it?https://reviews.llvm.org/D144911?id=500896
It *was* in the first revision of the patch, but it's not in the current one.
The phabricator commit history tracks evolution of the single patch, not a
dependent set of patches. If you need a dependent patch, that's done via
submitting each patch individually (i.e. with its own phabricator ID) and then
recording their relationship via "Edit related revisions -> Edit child/parent
revisions". After that you will see them arranged under "stack" sub-tab in the
"Revision contents" section
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144911/new/
https://reviews.llvm.org/D144911
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
