ychen added inline comments.
================ Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1059-1062 + case CodeSynthesisContext::BuildingDeductionGuides: + assert( + false && + "failed building deduction guides, add meaningful diagnostics here"); ---------------- cor3ntin wrote: > ychen wrote: > > aaron.ballman wrote: > > > cor3ntin wrote: > > > > This seems unfinished > > > +1 > > I meant to keep this a future work since this path is dead until some > > errors could be thrown out of this context. In the future, if errors > > happen during building deduction guides, this assertion failure could > > trigger at build time. > In this case, maybe change the message > assert(false && "unexpected deduction guide in instantiation stack") or > something along those lines. Done. I've made it `llvm_unreachable` to catch the rare chances that users hit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
