craig.topper added inline comments.
================
Comment at: clang/include/clang/Basic/RISCVVTypes.def:224
+RVV_VECTOR_TYPE_INT("__rvv_uint8m4x2_t", RvvUint8m4x2, RvvUint8m4x2Ty, 32, 8,
2, false)
+//===- Int16 tuple types
--------------------------------------------------===//
+RVV_VECTOR_TYPE_INT("__rvv_int16mf4x2_t", RvvInt16mf4x2, RvvInt16mf4x2Ty, 1,
16, 2, true)
----------------
Blank line before the start of each section
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:161
+ switch(NF) {
+ case 2: return VectorTypeModifier::Tuple2;
+ case 3: return VectorTypeModifier::Tuple3;
----------------
`case` should start at the same column as `switch`
================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:163
+ case 3: return VectorTypeModifier::Tuple3;
+ case 4:
+ return VectorTypeModifier::Tuple4;
----------------
Inconsistent formatting between case 2-3 and 4-8.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152070/new/
https://reviews.llvm.org/D152070
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
