phosek added a comment.
I'd split the `llvm/` changes into a separate change.
================
Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:58-59
+ !C.getDriver().IsCLMode() && !C.getDriver().IsFlangMode()) {
+ CmdArgs.push_back("-defaultlib:libcmt");
+ CmdArgs.push_back("-defaultlib:oldnames");
+ }
----------------
I don't think these should be needed for UEFI targets.
================
Comment at: llvm/test/ExecutionEngine/RuntimeDyld/X86/coff-alignment.ll:4
; RUN: opt -mtriple=x86_64-pc-win32-coff %s -o - | lli
+; RUN: opt -mtriple=x86_64-unknown-coff %s -o - | lli
----------------
Should this be `uefi`?
================
Comment at: llvm/test/Instrumentation/InstrProfiling/profiling.ll:10
; RUN: opt < %s -mtriple=x86_64-pc-win32-coff -passes=instrprof -S |
FileCheck %s --check-prefixes=COFF
+; RUN: opt < %s -mtriple=x86_64-unknown-coff -passes=instrprof -S | FileCheck
%s --check-prefixes=COFF
; RUN: opt < %s -mtriple=powerpc64-ibm-aix-xcoff -passes=instrprof -S |
FileCheck %s --check-prefixes=XCOFF
----------------
Should this be `uefi`?
================
Comment at: llvm/test/Transforms/PGOProfile/comdat_rename.ll:3
; RUN: opt < %s -mtriple=x86_64-pc-win32-coff -passes=pgo-instr-gen
-do-comdat-renaming=true -S | FileCheck %s
+; RUN: opt < %s -mtriple=x86_64-unknown-coff -passes=pgo-instr-gen
-do-comdat-renaming=true -S | FileCheck %s
----------------
Should this be `uefi`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131594/new/
https://reviews.llvm.org/D131594
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
