balazske added inline comments.

================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:553
   HelpText<"Check stream handling functions">,
+  WeakDependencies<[NonNullParamChecker]>,
   Documentation<HasDocumentation>;
----------------
steakhal wrote:
> What's the purpose of this hunk?
The intent was that `NonNullParamChecker` should find a null pointer problem 
before `StreamChecker` and have a fixed priority of the warnings. But 
NonNullParamChecker probably does not apply to the stream functions because 
there are no nonnull attributes (this may be possible?) and no references. No 
tests fail if this line is removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152169/new/

https://reviews.llvm.org/D152169

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to