akshaykhadse added a comment. If we could get rid of `BaseReg = BaseReg ? BaseReg : 1;` in `X86AsmParser::CreateMemForMSInlineAsm`, then we don't need any changes in the `X86Operand.h`. F27787125: image.png <https://reviews.llvm.org/F27787125>
I was not able to find any failing tests after making the change. But, this has existed for 11 years in the codebase, so I am not sure if making this change will break things in unexpected ways. Let me know what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
