jansvoboda11 added inline comments.
================ Comment at: clang/include/clang/Lex/HeaderSearch.h:763 /// find this file due to requirements from \p RequestingModule. - bool findUsableModuleForHeader(const FileEntry *File, + bool findUsableModuleForHeader(OptionalFileEntryRef File, const DirectoryEntry *Root, ---------------- jansvoboda11 wrote: > benlangmuir wrote: > > This should probably be non-Optional. I can't find any calls to this API > > that can pass null, they all pass something that is already being > > dereferenced. > You're right, thanks. Fixed in the committed version. *In the new revision, rather. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151854/new/ https://reviews.llvm.org/D151854 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits