brendandahl marked 12 inline comments as done.
brendandahl added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7645
+ if (FD->isThisDeclarationADefinition()) {
+ S.Diag(D->getLocation(), diag::err_alias_is_definition) << FD << 0;
+ return;
----------------
aaron.ballman wrote:
> This diagnostic doesn't make sense to me -- how does this attribute relate to
> ifuncs or aliases? Why should users be prohibited from writing the attribute
> on a definition?
This was from a previous version, it's not needed anymore. I'll remove.
================
Comment at: llvm/test/MC/WebAssembly/async.s:10-11
+
+.section .custom_section.async,"",@
+ .int32 foo@FUNCINDEX
+
----------------
brendandahl wrote:
> aheejin wrote:
> > The intention looks little weird.. Is that what `llc` emits?
> Yeah, I wasn't really sure how to format, but that's what llc was doing. Open
> to changing it.
Actually, it does look like something got messed up. I'll fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150803/new/
https://reviews.llvm.org/D150803
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
