dzhidzhoev added a comment. In D143984#4362988 <https://reviews.llvm.org/D143984#4362988>, @dblaikie wrote:
> In D143984#4358115 <https://reviews.llvm.org/D143984#4358115>, @dzhidzhoev > wrote: > >> In D143984#4357517 <https://reviews.llvm.org/D143984#4357517>, @dblaikie >> wrote: >> >>> Looks like this series got approved - is it waiting on any particular >>> feedback, or do you need someone to commit it for you? >> >> I had been waiting for approval for the change of >> https://reviews.llvm.org/D144008. How would you suggest landing these >> commits - individually or all at once? > > Ah, fair enough. > > It's a tough balance - committing them all at once can make it difficult to > see which specific change is the cause of a regression/buildbot failure/etc. > But committing them too far apart can cause large chunks of breakage/harder > to revert, etc. So... probably close-ish together, let the bots give you some > results before pushing the next patch, maybe? Agreed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
