vikramRH marked 2 inline comments as done. vikramRH added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1030 NegFlag<SetFalse>>; +def mprintf_kind_EQ : Joined<["-"], "mprintf-kind=">, Group<m_Group>, + HelpText<"Specify the printf lowering scheme (AMDGPU only), allowed values are " ---------------- arsenm wrote: > I'm a bit worried this is introducing a side-ABI option not captured in the > triple or at least module flags I did not understand the concern here. I agree The usage of option itself is not the most robust solution and it would have been better if we could do this without user intervention. but I do not see ways to do that now (atleast not immediately). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
