erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
1 nit, feel free to do this as a part of the commit. ================ Comment at: clang/lib/Sema/ParsedAttr.cpp:208 + // The appurtenance rules are applied strictly for all regular keyword + // atributes. + return false; ---------------- Humorously, I spent an absurd amount of time trying to figure out whether appurtenance was a word/the correct spelling, determined you had it right and closed the phab review box, just to see `atributes` :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148702/new/ https://reviews.llvm.org/D148702 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
