PiotrZSL added inline comments.
================ Comment at: clang-tools-extra/unittests/clang-tidy/IncludeCleanerTest.cpp:9 +#include <vector> + +using namespace clang::tidy::misc; ---------------- PiotrZSL wrote: > this test file is fine, but there is no validation of output warning. > nwm, somehow I missed one file. ================ Comment at: clang-tools-extra/unittests/clang-tidy/IncludeCleanerTest.cpp:19 +#include "bar.h" +#include <vector> +#include "bar.h" ---------------- make sure that those tests does not depend on actual system headers (check what headers are included here). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
