benlangmuir accepted this revision.
benlangmuir added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/include/clang/Basic/Module.h:160
+ llvm::PointerUnion<const FileEntryRef::MapEntry *,
+ const DirectoryEntryRef::MapEntry *>
Umbrella;
----------------
Would it make sense to implement `PointerLikeTypeTraits` for
FileEntryRef/DirectoryEntryRef so you don't need to use the MapEntry explicitly?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151584/new/
https://reviews.llvm.org/D151584
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
