[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

Just 1 change I'd like, but otherwise this LGTM.



================
Comment at: clang/lib/AST/AttrImpl.cpp:244
+  assert(!isAlignmentDependent());
+  auto getAlignmentImpl = [&]() -> unsigned {
+    if (isAlignmentExpr()) {
----------------
I don't think it makes sense to make this a lambda here rather than just 
implementing it inline if the value isn't cached.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150528/new/

https://reviews.llvm.org/D150528

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits