pcwang-thead added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:41 +// Helper function to get the largest LMUL from MxList +// Precondition: MxList is sorted in ascending LMUL order. ---------------- michaelmaitland wrote: > michaelmaitland wrote: > > pcwang-thead wrote: > > > So, are we going to discard `LMULXXXImpl` below? > > I will use `LMULXXXImpl` in a follow up NFC patch. This code below comes > > from before `LMULXXXImpl` was introduced. > Can you please provide an example of how you intend on this being used today? > I think it depends on https://reviews.llvm.org/D146198 since if we use > `LMULXXXImpl` today, there is no way to differentiate behavior based on LMUL. An example is the old version of this patch(https://reviews.llvm.org/D146198?vs=on&id=509607#toc) and the comment(https://reviews.llvm.org/D146198?vs=on&id=509607#4232814). Maybe you can wait for the approval of these patches if we're gonna change it anyway. So I think there is no need to change it currently. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
