michaelmaitland added inline comments.
================
Comment at: clang/lib/Sema/Sema.cpp:2049
+ !TI.hasFeature("experimental-zvfhmin"))
+ Diag(Loc, diag::err_riscv_type_requires_extension, FD) << Ty << "zvfh";
if (Ty->isRVVType(/* Bitwidth */ 32, /* IsFloat */ true) &&
----------------
michaelmaitland wrote:
> Should this output `zvfhmin` instead of `zvfh` when `experimental-zvfhmin`
> feature is not included?
Or maybe it makes more sense to change `"zvfh"` to `"zvfh or zvfhmin"`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150253/new/
https://reviews.llvm.org/D150253
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
