nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land.
This also resolves https://github.com/llvm/llvm-project/issues/62482; was that intentional? If so, consider adding a link to https://github.com/llvm/llvm-project/issues/62482 to this commit description (or closing https://github.com/llvm/llvm-project/issues/62482 as a duplicate of https://github.com/llvm/llvm-project/issues/60116 if that makes more sense). ================ Comment at: llvm/lib/IR/Module.cpp:675-684 +bool Module::getDirectAccessExternalData() const { + auto *Val = cast_or_null<ConstantAsMetadata>(getModuleFlag("direct-access-external-data")); + if (Val) + return cast<ConstantInt>(Val->getValue())->getZExtValue() > 0; + return getPICLevel() == PICLevel::NotPIC; +} + ---------------- I think the presubmit bot failed due to clang-format changes to code introduced in this hunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150841/new/ https://reviews.llvm.org/D150841 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
